Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="CLAUDE.md">
<violation number="1" location="CLAUDE.md:94">
P3: The docs incorrectly say a pre-commit hook enforces Conventional Commits; this repository enforces it via commit-msg.</violation>
</file>
Architecture diagram
sequenceDiagram
participant User as User (Engineer)
participant Claude as Claude Code (Agent)
participant GH as GitHub (gh CLI)
participant FS as Local Filesystem (Rules/Code)
participant Env as Dev Environment (Make/Go)
participant Git as Git (VCS)
Note over Claude,Git: NEW: Workflow for /pick-up-issue <issue-number>
User->>Claude: Invoke /pick-up-issue
rect rgb(240, 240, 240)
Note right of Claude: Phase 1: Context Gathering
Claude->>GH: Fetch issue, comments, and linked PRs
GH-->>Claude: Issue metadata & discussion
Claude->>FS: NEW: Load CLAUDE.md and .claude/rules/
FS-->>Claude: Architecture constraints & translator rules
Claude->>FS: Survey relevant Go packages and tests
end
rect rgb(230, 240, 255)
Note right of Claude: Phase 2: Planning (Gate 1)
Claude->>Claude: Analyze gaps in TypeResolver/EnrichField
Claude->>User: Present implementation plan & test strategy
User-->>Claude: Explicit Approval
end
rect rgb(240, 240, 240)
Note right of Claude: Phase 3: Implementation
Claude->>Git: Create branch from origin/main
Claude->>FS: Write code, templates, and table tests
loop Incremental Validation
Claude->>Env: NEW: Run make format, lint, test, build
Env-->>Claude: Exit codes & failure logs
opt If failures occur
Claude->>FS: Fix underlying code/tests
end
end
end
rect rgb(230, 240, 255)
Note right of Claude: Phase 4: Pushing (Gate 2)
Claude->>User: Show git diff stat & final test results
User-->>Claude: Explicit Approval
Claude->>Git: Push branch to origin
end
rect rgb(230, 240, 255)
Note right of Claude: Phase 5: Pull Request (Gate 3)
Claude->>User: Show drafted PR title & body (Conventional Commits)
User-->>Claude: Explicit Approval
Claude->>GH: Run gh pr create
GH-->>Claude: PR URL
Claude->>User: Return PR URL
end
Note over FS,Env: NEW: Translator Rules Enforcement
Note right of Env: Rules require: License headers, Package comments, <br/>internal/ only API, and Prepare pipeline usage.
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> Signed-off-by: Gudmundur Orri Palsson <g.palsson@daco.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add claude init instructions and commands to research and work on issues